[No Jira] fix color edit tab navigation#368
Merged
meganthecoder merged 2 commits intostagefrom Apr 20, 2026
Merged
Conversation
Contributor
meganthecoder
left a comment
meganthecoder
left a comment
There was a problem hiding this comment.
Can you fix the merge conflicts with stage? Then I can test the popover with my recent changes.
Contributor
Author
|
@meganthecoder I have fixed merge conflicts. Please take a look. |
meganthecoder
approved these changes
Apr 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Focus & Keyboard Accessibility Fixes for Color Editor
Focus returns to strip after closing the color editor
When editing a color via the hex code on a strip, pressing Escape or clicking outside to close the editor would lose keyboard focus entirely — it would jump to the toolbar instead of staying on the strip the user was working on. This has been fixed so focus returns to the correct color strip, allowing users to continue navigating with the keyboard seamlessly.
Arrow keys now work on color area and hue slider handles
The color area (saturation/brightness) and hue slider handles inside the color editor were unresponsive to arrow keys. Users relying on keyboard navigation couldn't adjust colors at all. This was caused by a snap-to-original-color feature that was too aggressive for the small increments keyboard input produces, effectively canceling every adjustment. The fix preserves the snap behavior for mouse/touch users (where it helps return to the original color) while allowing keyboard users to make fine-grained adjustments with arrow keys as expected.
Jira Ticket
Resolves: MWPW-NUMBER
Test URLs
Verification Steps
Potential Regressions
Additional Notes
(If applicable) Add context, related PRs, or known issues here.